Clean up GUIDE compatibility review comments

Agent-Logs-Url: https://github.com/kk14222/3D_EDFM_SIM-X/sessions/a128ab7f-6b94-4048-a847-f2dc37bbe0ab

Co-authored-by: kk14222 <217880052+kk14222@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-28 03:36:09 +00:00
committed by GitHub
co-authored by kk14222
parent 2447ff62f6
commit 421696c5e0
5 changed files with 21 additions and 9 deletions
+10 -1
View File
@@ -1527,10 +1527,19 @@ classdef EDFMAppController < handle
try try
uialert(obj.App.UIFigure, message, titleText, varargin{:}); uialert(obj.App.UIFigure, message, titleText, varargin{:});
catch catch
errordlg(char(string(message)), char(string(titleText)), 'modal'); errordlg(obj.toDialogText(message), obj.toDialogText(titleText), 'modal');
end end
end end
function textValue = toDialogText(~, value)
if iscell(value)
textValue = strjoin(string(value), newline);
else
textValue = string(value);
end
textValue = char(textValue);
end
function textValue = formatExceptionSummary(~, ME) function textValue = formatExceptionSummary(~, ME)
lines = { lines = {
sprintf('Error: %s', ME.message) sprintf('Error: %s', ME.message)
+7 -4
View File
@@ -55,8 +55,7 @@ classdef EDFMGuideComponent < handle
case 'slider' case 'slider'
value = get(obj.Handle, 'Value'); value = get(obj.Handle, 'Value');
case 'edit' case 'edit'
userData = get(obj.Handle, 'UserData'); if obj.isNumericEditField()
if isstruct(userData) && isfield(userData, 'Type') && strcmp(userData.Type, 'numeric')
value = str2double(string(get(obj.Handle, 'String'))); value = str2double(string(get(obj.Handle, 'String')));
if isnan(value) if isnan(value)
value = []; value = [];
@@ -94,8 +93,7 @@ classdef EDFMGuideComponent < handle
case 'slider' case 'slider'
set(obj.Handle, 'Value', double(value)); set(obj.Handle, 'Value', double(value));
case 'edit' case 'edit'
userData = get(obj.Handle, 'UserData'); if obj.isNumericEditField()
if isstruct(userData) && isfield(userData, 'Type') && strcmp(userData.Type, 'numeric')
if isempty(value) if isempty(value)
set(obj.Handle, 'String', ''); set(obj.Handle, 'String', '');
else else
@@ -276,6 +274,11 @@ classdef EDFMGuideComponent < handle
style = ''; style = '';
end end
end end
function tf = isNumericEditField(obj)
userData = get(obj.Handle, 'UserData');
tf = isstruct(userData) && isfield(userData, 'Type') && strcmp(userData.Type, 'numeric');
end
end end
methods (Static, Access = private) methods (Static, Access = private)
+2 -2
View File
@@ -11,7 +11,7 @@ if nargin > 0 && ischar(varargin{1})
end end
startup; startup;
handles = loadOrCreateGuideLayout(); handles = initializeGuideLayout();
fig = handles.UIFigure; fig = handles.UIFigure;
app = EDFMGuideApp(handles); app = EDFMGuideApp(handles);
app.Controller = EDFMAppController(app); app.Controller = EDFMAppController(app);
@@ -25,7 +25,7 @@ if nargout > 0
end end
end end
function handles = loadOrCreateGuideLayout() function handles = initializeGuideLayout()
figFile = fullfile(fileparts(mfilename('fullpath')), 'EDFMSimulatorGuide.fig'); figFile = fullfile(fileparts(mfilename('fullpath')), 'EDFMSimulatorGuide.fig');
if exist(figFile, 'file') == 2 if exist(figFile, 'file') == 2
fig = openfig(figFile, 'reuse', 'invisible'); fig = openfig(figFile, 'reuse', 'invisible');
@@ -1,6 +1,6 @@
function handles = createEDFMSimulatorGuideLayout() function handles = createEDFMSimulatorGuideLayout()
%CREATEEDFMSIMULATORGUIDELAYOUT Build the GUIDE-compatible EDFM GUI layout. %CREATEEDFMSIMULATORGUIDELAYOUT Build the GUIDE-compatible EDFM GUI layout.
% This file is generated from gui_support/app/context.txt to preserve the App Designer layout. % This layout mirrors the exported App Designer source in context.txt when available.
fig = figure('Visible', 'off', 'Name', 'EDFM Simulator', 'NumberTitle', 'off', ... fig = figure('Visible', 'off', 'Name', 'EDFM Simulator', 'NumberTitle', 'off', ...
'MenuBar', 'none', 'ToolBar', 'none', 'Resize', 'on', 'Units', 'pixels', ... 'MenuBar', 'none', 'ToolBar', 'none', 'Resize', 'on', 'Units', 'pixels', ...
+1 -1
View File
@@ -1,5 +1,5 @@
function app = launch_edfm_simulator_app() function app = launch_edfm_simulator_app()
%LAUNCH_EDFM_SIMULATOR_APP Launch the EDFM Simulator GUI. %LAUNCH_EDFM_SIMULATOR_APP General EDFM GUI launcher.
% MATLAB R2022a-compatible GUIDE/uicontrol implementation is used by default. % MATLAB R2022a-compatible GUIDE/uicontrol implementation is used by default.
startup; startup;